Page 1 of 2

Autonote not visible via "Edit Player Note"

PostPosted: Fri Jul 20, 2012 9:40 am
by pasita
If I create a report and click "Edit Player Note", I get the notes box but autonotes are not shown there. When I open the same player's notes from HUD the autonotes are now visible.

Re: Autonote not visible via "Edit Player Note"

PostPosted: Fri Jul 20, 2012 10:58 am
by kraada
That's because autonotes are tied to a game type - that way you don't see omaha notes when playing holdem and vice versa, you don't see fixed limit notes when playing no limit, etc.

When looking via the Edit Player Note window, there's no known gametype, so we don't display anything.

Re: Autonote not visible via "Edit Player Note"

PostPosted: Fri Jul 20, 2012 1:54 pm
by pasita
I would have thought the logical thing to do is display everything (maybe based on filters on the report page?), although I can see the logic going the other way also. At least, it would be more useful to display everything instead of nothing in this case imo. Or display a message saying "nothing is displayed" as it's a bit confusing the way it is now...

Re: Autonote not visible via "Edit Player Note"

PostPosted: Fri Jul 20, 2012 4:50 pm
by kraada
I understand, it's a valid point. I'll talk it over with the NoteTracker developer to see if we can find a better solution.

Re: Autonote not visible via "Edit Player Note"

PostPosted: Tue Jul 31, 2012 11:32 am
by pasita
This thing came back to me as the same thing was discussed on the 2+2 thread lately.
I'm not sure I see why the note tracker developer has anything to do with this as the note is already accessible in the db... isn't it about what you query when creating the Note box?

Re: Autonote not visible via "Edit Player Note"

PostPosted: Tue Jul 31, 2012 12:20 pm
by kraada
The Autonotes are only displayed when matched to a specific game type - when you open the window from a non-replayer area there is no game type and as such we'll need to develop some method for handling that scenario.

Re: Autonote not visible via "Edit Player Note"

PostPosted: Tue Jul 31, 2012 12:39 pm
by pasita
Yeah I understand that part... but you can easily query for all the game types if no game type is present. I understand you may need to sit back for a minute to decide how to display the data.

Re: Autonote not visible via "Edit Player Note"

PostPosted: Tue Jul 31, 2012 1:45 pm
by tarix
pasita wrote:you can easily query for all the game types if no game type is present.


The auto notes were not designed to allow this. This is one of many design changes that are on our list of improvements for NoteTracker.

Re: Autonote not visible via "Edit Player Note"

PostPosted: Tue Jul 31, 2012 1:57 pm
by pasita
"select note from notes_auto"
works for me, brings notes from several game types.

Re: Autonote not visible via "Edit Player Note"

PostPosted: Tue Jul 31, 2012 2:00 pm
by pasita
While at it: id_hands in the notes_auto table seems to carry only one hand id atm.

highfalutin